Forward the compilation database path to the LS. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tha path to the compilation database is optional. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
silvanocerza
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path to the compilation database is optional.
Signed-off-by: Akos Kitta kittaakos@typefox.io
@silvanocerza, could you please look into my changes. This PR is supposed to do the following: if the
compileCommandsPathproperty is set, it will start the Arduino LS with this extra info. Otherwise, it must behave as it was. This PR is required for arduino/arduino-language-server#35.Thank you!